Update closest_points.rs #878
Conversation
Adding edge case for large dataset.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 95.50% 95.49% -0.01%
==========================================
Files 317 317
Lines 22948 22960 +12
==========================================
+ Hits 21916 21926 +10
- Misses 1032 1034 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vil02
left a comment
vil02
left a comment
There was a problem hiding this comment.
@syed-ghufran-hassan: could you please explain what value does this test case add? In other words: what is the new situation, which it covers?
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This needs to be added because the algorithm does not cover large datasets, high precision and floating points comparison in range |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel. Thank you for your contributions! |
3 participants
Adding edge case for large dataset.
Pull Request Template
Description
Please include a summary of the change and which issue (if any) is fixed.
A brief description of the algorithm and your implementation method can be helpful too. If the implemented method/algorithm is not so
well-known, it would be helpful to add a link to an article explaining it with more details.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.